Re: [PATCH v2 02/10] mfd: wcd9335: add support to wcd9335 core

[Srinivas Kandagatla]

Thanks for reviewing,

On 30/07/18 05:12, Vinod wrote:
> On 27-07-18, 13:17, Srinivas Kandagatla wrote:
> > +obj-$(CONFIG_MFD_WCD9335)	+= wcd9335.o
> > +wcd9335-objs			:= wcd9335-core.o
> > +
>
> no slimbus objs?
Yep, I will try to tidy this up a bit in next version.
> > +static int wcd9335_bring_up(struct wcd9335 *wcd)
> > +{
> > +	struct regmap *rm = wcd->regmap;
> > +	int val, byte0;
> > +	int ret = 0;
> > +
> > +	regmap_read(rm, WCD9335_CHIP_TIER_CTRL_EFUSE_VAL_OUT0, &val);
> > +	regmap_read(rm, WCD9335_CHIP_TIER_CTRL_CHIP_ID_BYTE0, &byte0);
> > +
> > +	if ((val < 0) || (byte0 < 0)) {
> > +		dev_err(wcd->dev, "wcd9335 codec version detection fail!\n");
> > +		return -EINVAL;
> > +	}
> > +
> > +	if (byte0 == 0x1) {
> > +		dev_info(wcd->dev, "wcd9335 codec version is v2.0\n");
> > +		wcd->version = WCD9335_VERSION_2_0;
> > +		regmap_write(rm, WCD9335_CODEC_RPM_RST_CTL, 0x01);
> > +		regmap_write(rm, WCD9335_SIDO_SIDO_TEST_2, 0x00);
> > +		regmap_write(rm, WCD9335_SIDO_SIDO_CCL_8, 0x6F);
> > +		regmap_write(rm, WCD9335_BIAS_VBG_FINE_ADJ, 0x65);
> > +		regmap_write(rm, WCD9335_CODEC_RPM_PWR_CDC_DIG_HM_CTL, 0x5);
> > +		regmap_write(rm, WCD9335_CODEC_RPM_PWR_CDC_DIG_HM_CTL, 0x7);
> > +		regmap_write(rm, WCD9335_CODEC_RPM_PWR_CDC_DIG_HM_CTL, 0x3);
> > +		regmap_write(rm, WCD9335_CODEC_RPM_RST_CTL, 0x3);
> > +	} else {
> > +		dev_err(wcd->dev, "wcd9335 codec version not supported\n");
> > +		ret = -EINVAL;
> > +	}
> > +
> > +	return ret;
>
> we can do return 0 and remove the variable as it is not used anywhere
> else.
Yes, it makes sense!


Thanks,
srini