Re: [PATCH] mmc: mxcmmc: Fix missing parentheses and brace

[Ulf Hansson]

On 31 July 2018 at 22:27, Kees Cook <keescook@xxxxxxxxxxxx> wrote:
> On Mon, Jul 16, 2018 at 3:11 AM, Ulf Hansson <ulf.hansson@xxxxxxxxxx> wrote:
>> On 12 July 2018 at 21:59, Kees Cook <keescook@xxxxxxxxxxxx> wrote:
>>> Looks like the adjusted syntax wasn't fully build tested. This fixes
>>> failures with powerpc builds:
>>>
>>> drivers/mmc/host/mxcmmc.c: In function âmxcmci_swap_buffersâ:
>>> drivers/mmc/host/mxcmmc.c:296:51: error: expected â)â before â;â token
>>>    void *buf = kmap_atomic(sg_page(sg) + sg->offset;
>>>                                                    ^
>>> drivers/mmc/host/mxcmmc.c:299:1: error: expected â,â or â;â before â}â token
>>>  }
>>>  ^
>>>
>>> Fixes: b189e7589f6d3 ("mmc: mxcmmc: handle highmem pages")
>>> Signed-off-by: Kees Cook <keescook@xxxxxxxxxxxx>
>>
>> Thanks, applied for fixes!
>
> I just checked again, and while I see this in linux-next, I would
> expect this to be in 4.18, since this fixes a 4.18-introduced build
> failure for some PPC configurations. Can this please be included in
> 4.18?

Yes it will, I was just about to create a PR for it.

However, I have deliberately slowed down the pace of sending fixes to
Linus, because of trying to achieve a somewhat better test coverage.

If you want to test the latest 4.18 rcs with pending fixes, we have
the pending-fixes branch in Stephen's next tree.

[...]

Kind regards
Uffe