Re: Commit "new primitive: discard_new_inode()" introduces a problem

[Al Viro]

On Wed, Aug 01, 2018 at 06:43:56PM +0300, Kirill Tkhai wrote:
> #git status
> HEAD detached at 22dc9a168272

Wait a sec - just that commit?  With discard_new_inode() not even
used anywhere?  Then any of those -ENOMEM is disguised ERR_PTR(-ESTALE)
from find_inode()/find_inode_fast(), i.e. an inode found by
iget5_locked() (your /etc is on ext4) with I_CREATING still set.
And that is set only by insert_inode_locked()/insert_inode_locked4(),
and only until unlock_new_inode().

Could you slap WARN_ON(1) before these return ERR_PTR(-ESTALE) in
find_inode{,_fast}() and see if that's what's getting triggered?