Re: [PATCH 1/1] x86, pmem, acpi: Remove excessive ACPI Large Reference Count warnings

[Russ Anderson]

On Wed, Aug 01, 2018 at 07:49:14PM +0000, Moore, Robert wrote:
> Are there any actual memory leaks, or this a consequence of the number of sockets?

It is a consequence of the number of sockets.
It is not an actual memory leak.

Thanks.

> > -----Original Message-----
> > From: Mike Travis [mailto:mike.travis@xxxxxxx]
> > Sent: Monday, July 30, 2018 12:56 PM
> > To: Moore, Robert <robert.moore@xxxxxxxxx>; Schmauss, Erik
> > <erik.schmauss@xxxxxxxxx>; Wysocki, Rafael J
> > <rafael.j.wysocki@xxxxxxxxx>; Len Brown <lenb@xxxxxxxxxx>
> > Cc: Russ Anderson <russ.anderson@xxxxxxx>; Dimitri Sivanich
> > <dimitri.sivanich@xxxxxxx>; Ross Zwisler <ross.zwisler@xxxxxxxxxxxxxxx>;
> > Williams, Dan J <dan.j.williams@xxxxxxxxx>; Verma, Vishal L
> > <vishal.l.verma@xxxxxxxxx>; Jiang, Dave <dave.jiang@xxxxxxxxx>; linux-
> > acpi@xxxxxxxxxxxxxxx; devel@xxxxxxxxxx; linux-nvdimm@xxxxxxxxxxxx;
> > linux-kernel@xxxxxxxxxxxxxxx
> > Subject: [PATCH 1/1] x86, pmem, acpi: Remove excessive ACPI Large
> > Reference Count warnings
> > 
> > With the Intel BIOS support for 8 processor sockets with a full
> > complement of NVDIMMS potentially installable, and there are empty
> > sockets without NVDIMMS, there is an extremely large amount of the
> > following warnings:
> > 
> > ACPI Warning: Large Reference Count (0x1001) in object ffff99453fc71750,
> > 	Type=0x0A
> > 
> > On a 4 socket system with 4 NVDIMMs there were over 6000 of these
> > warning messages and it has been seem on systems from 4 to 32 sockets.
> > 
> > Through some guidance from the BIOS developers and testing, it appears
> > that simply bumping up the threshold for warnings from 0x1000 to 0x2000
> > eliminates these messages.  Changing them to be ACPI DEBUG messages, or
> > even removing them are other options, but it would then defeat the
> > purpose of the warnings as the problem would effectively be hidden.
> > 
> > Reviewed-by: Dimitri Sivanich <dimitri.sivanich@xxxxxxx>
> > Tested-by: Russ Anderson <russ.anderson@xxxxxxx>
> > Signed-off-by: Mike Travis <mike.travis@xxxxxxx>
> > ---
> >  include/acpi/acconfig.h |    2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > --- linux-4.12.orig/include/acpi/acconfig.h
> > +++ linux-4.12/include/acpi/acconfig.h
> > @@ -123,7 +123,7 @@
> > 
> >  /* Maximum object reference count (detects object deletion issues) */
> > 
> > -#define ACPI_MAX_REFERENCE_COUNT        0x1000
> > +#define ACPI_MAX_REFERENCE_COUNT        0x2000
> > 
> >  /* Default page size for use in mapping memory for operation regions */
> > 
> > 
> > --
> 

-- 
Russ Anderson,  SuperDome Flex Linux Kernel Group Manager
HPE - Hewlett Packard Enterprise (formerly SGI)  rja@xxxxxxx