[PATCH] fs: dcache: Use true and false for boolean values

From: Gustavo A. R. Silva
Date: Wed Aug 01 2018 - 20:39:09 EST


Return statements in functions returning bool should use true or false
instead of an integer value.

This issue was detected with the help of Coccinelle.

Signed-off-by: Gustavo A. R. Silva <gustavo@xxxxxxxxxxxxxx>
---
fs/dcache.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/fs/dcache.c b/fs/dcache.c
index b928915..8c07ab1 100644
--- a/fs/dcache.c
+++ b/fs/dcache.c
@@ -733,16 +733,16 @@ static inline bool fast_dput(struct dentry *dentry)
if (dentry->d_lockref.count > 1) {
dentry->d_lockref.count--;
spin_unlock(&dentry->d_lock);
- return 1;
+ return true;
}
- return 0;
+ return false;
}

/*
* If we weren't the last ref, we're done.
*/
if (ret)
- return 1;
+ return true;

/*
* Careful, careful. The reference count went down
@@ -771,7 +771,7 @@ static inline bool fast_dput(struct dentry *dentry)

/* Nothing to do? Dropping the reference was all we needed? */
if (d_flags == (DCACHE_REFERENCED | DCACHE_LRU_LIST) && !d_unhashed(dentry))
- return 1;
+ return true;

/*
* Not the fast normal case? Get the lock. We've already decremented
@@ -788,7 +788,7 @@ static inline bool fast_dput(struct dentry *dentry)
*/
if (dentry->d_lockref.count) {
spin_unlock(&dentry->d_lock);
- return 1;
+ return true;
}

/*
@@ -797,7 +797,7 @@ static inline bool fast_dput(struct dentry *dentry)
* set it to 1.
*/
dentry->d_lockref.count = 1;
- return 0;
+ return false;
}


--
2.7.4