Re: [PATCH] fs/binfmt_elf: remove the same condition check

From: Matthew Wilcox
Date: Wed Aug 01 2018 - 22:34:23 EST


On Thu, Aug 02, 2018 at 10:00:28AM +0800, zhong jiang wrote:
> dump_align is used to double check in a expression. It is redundant.
> so just remove one of them.

You're wrong. Functions in C can have side-effects (and this one does).