Re: [PATCH] fs/binfmt_elf_fdpic: remove redundant condition check in writenote
From: zhong jiang
Date: Wed Aug 01 2018 - 22:52:00 EST
plese ingore it.
On 2018/8/2 10:04, zhong jiang wrote:
> It is unncessary to use double test for a expression. so just
> remove one of them.
>
> Signed-off-by: zhong jiang <zhongjiang@xxxxxxxxxx>
> ---
> fs/binfmt_elf_fdpic.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/binfmt_elf_fdpic.c b/fs/binfmt_elf_fdpic.c
> index b53bb37..5162372 100644
> --- a/fs/binfmt_elf_fdpic.c
> +++ b/fs/binfmt_elf_fdpic.c
> @@ -1288,7 +1288,7 @@ static int writenote(struct memelfnote *men, struct coredump_params *cprm)
>
> return dump_emit(cprm, &en, sizeof(en)) &&
> dump_emit(cprm, men->name, en.n_namesz) && dump_align(cprm, 4) &&
> - dump_emit(cprm, men->data, men->datasz) && dump_align(cprm, 4);
> + dump_emit(cprm, men->data, men->datasz);
> }
>
> static inline void fill_elf_fdpic_header(struct elfhdr *elf, int segs)