Re: [PATCH v2] staging: mt29f_spinand: fix memory leak while programming pages

From: Greg KH
Date: Thu Aug 02 2018 - 12:02:58 EST

A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?

A: No.
Q: Should I include quotations after my reply?

On Thu, Aug 02, 2018 at 04:31:40PM +0800, Jheng-Jhong Wu wrote:
> Dear greg k-h,
> Before device is removed and freed memory automatically, programming
> pages may run many many times.

What do you mean by "programming pages"?

> Assume we erase and rewrite a large part of the flash, then
> spinand_program_page() might exhaust memory if memory is not large
> enough.

I do not understand what you mean here.

> We may not remove and re-add the device between each programming page, right?

I have no idea how your hardware works :)

> In fact, OOM indeed occurred when I tested programming multi-pages by
> mtd_debug tool.
> Erased first, then programmed pages.

Please provide more information like this in the patch when you resend
it, spelling out exactly why you are making this change. It is not that
the current code is "leaking" anything, it is that you want the
functionality to be different from what it currently is.


greg k-h