Re: [PATCH 1/3] PCI: xilinx-nwl: Save error IRQ number in device_node private data

From: Christoph Hellwig
Date: Thu Aug 02 2018 - 12:02:32 EST


> +#ifdef CONFIG_PCIEAER
> + struct device_node *node = dev->of_node;
> +#endif
>
> breg_val = nwl_bridge_readl(pcie, E_BREG_CAPABILITIES) & BREG_PRESENT;
> if (!breg_val) {
> @@ -744,6 +747,9 @@ static int nwl_pcie_bridge_init(struct nwl_pcie *pcie)
> pcie->irq_misc);
> return err;
> }
> +#ifdef CONFIG_PCIEAER
> + node->data = &pcie->irq_misc;
> +#endif

Is there any good reason for these ifdefs? Always assigning the node
data would seem harmless and much cleaner to me.