Re: [PATCH v2] staging: mt29f_spinand: fix memory leak while programming pages

From: Greg Kroah-Hartman
Date: Thu Aug 02 2018 - 12:02:35 EST

On Thu, Aug 02, 2018 at 03:51:30PM +0800, Jheng-Jhong Wu wrote:
> In spinand_program_page(), it uses devm_kzalloc() to allocate memory to
> wbuf dynamically if internal ECC is on, but it doesn't free memory
> allocated to wbuf at the end of this function. Before the spinand device
> is removed and frees memory automatically, programming pages may run many
> times. This leads to a memory leak issue when internal ECC is on.

How is this a memory leak? The memory will be freed when the struct
device is removed from the system. How did you test that there was a

> Changelog:
> v2:
> - use kzalloc()/kfree() to replace devm_kzalloc()/devm_kfree()
> - add some descriptions to commit message

this changelog goes below the --- line.


greg k-h