Re: [PATCH] lightnvm: pblk: take write semaphore on metadata

From: Javier Gonzalez
Date: Thu Aug 02 2018 - 12:04:58 EST




> On 2 Aug 2018, at 17.57, Jens Axboe <axboe@xxxxxxxxx> wrote:
>
>> On 8/2/18 7:47 AM, Javier GonzÃlez wrote:
>> Take the write semaphore on metadata I/Os too.
>
> I'm going to nit pick a little bit here, but this isn't a good
> changelog at all. A good changelog tells you _why_ a change is
> made, not how it's made. Your commit message doesn't really tell
> me anything that I can't easily glean from looking at the patch.
>
> A good commit message would tell me _why_ we are now also
> grabbing the write sem for metadata.
>
> --
> Jens Axboe
>

Youâre right. Iâll fix the commit message and resend tomorrow.

Javier