Re: [PATCH V2 2/2] blk-mq: fix blk_mq_tagset_busy_iter

From: Bart Van Assche
Date: Thu Aug 02 2018 - 14:46:59 EST


On Fri, 2018-08-03 at 01:49 +-0800, Ming Lei wrote:
+AD4- Commit d250bf4e776ff09d5(+ACI-blk-mq: only iterate over inflight requests
+AD4- in blk+AF8-mq+AF8-tagset+AF8-busy+AF8-iter+ACI-) uses 'blk+AF8-mq+AF8-rq+AF8-state(rq) +AD0APQ- MQ+AF8-RQ+AF8-IN+AF8-FLIGHT'
+AD4- to replace 'blk+AF8-mq+AF8-request+AF8-started(req)', this way is wrong, and causes
+AD4- lots of test system hang during booting.
+AD4-
+AD4- Fix the issue by using blk+AF8-mq+AF8-request+AF8-started(req) inside bt+AF8-tags+AF8-iter().

That's a good catch. Hence:

Reviewed-by: Bart Van Assche +ADw-bart.vanassche+AEA-wdc.com+AD4-