Re: [PATCH v1 1/1] gpio: mmio: add inverted direction get_set io support

From: Linus Walleij
Date: Thu Aug 02 2018 - 19:34:49 EST


On Mon, Jul 30, 2018 at 11:34 AM Tomer Maimon <tmaimon77@xxxxxxxxx> wrote:

> Add get_set_inv_dir and get_set_multiple_inv_dir I/O functions
> to call the data register when the dirction is input and
> set register when the direction is output.
> the functions will linked to the I/O get functions if the user set
> BGPIOF_INVERTED_REG_DIR flag in the bgpio initialization.
>
> Signed-off-by: Tomer Maimon <tmaimon77@xxxxxxxxx>

I think you uncovered a bug. This is however not the best fix IMO.

Sorry for not understanding the issue at first, I am sometimes
pretty slow in the head. :(

I'm sending a patch that I hope fixes the real problem in an
elegant way, and makes it possible to just define dirin and
BGPIOF_READ_OUTPUT_REG_SET.

Yours,
Linus Walleij