Re: [PATCH V8 2/5] mmc: sdhci: Change O2 Host HS200 mode clock frequency to 200MHz

[Adrian Hunter]

On 27/07/18 19:23, Ernest Zhang(WH) wrote:
> O2 SD Host HS200 mode clock frequency current is 208MHz, should be changed to 200MHz to meet specification.
> 
> Signed-off-by: ernest.zhang <ernest.zhang@xxxxxxxxxxxxxx>

Acked-by: Adrian Hunter <adrian.hunter@xxxxxxxxx>

> ---
> Change in V8:
> 	The set base clock code comment has been changed in accordance with
> 	code change in V7.
> 
> Change in V7:
> 	Change HS200 mode clock frequency from 208MHz to 200MHz to meet
> 	Specification.
> 
> Change in V1~V6:
> 	N/A
> ---
>  drivers/mmc/host/sdhci-pci-o2micro.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/mmc/host/sdhci-pci-o2micro.c b/drivers/mmc/host/sdhci-pci-o2micro.c
> index ba59db6a126c..9e7bacda4717 100644
> --- a/drivers/mmc/host/sdhci-pci-o2micro.c
> +++ b/drivers/mmc/host/sdhci-pci-o2micro.c
> @@ -311,9 +311,9 @@ int sdhci_pci_o2_probe(struct sdhci_pci_chip *chip)
>  
>  			/* Check Whether subId is 0x11 or 0x12 */
>  			if ((scratch_32 == 0x11) || (scratch_32 == 0x12)) {
> -				scratch_32 = 0x2c280000;
> +				scratch_32 = 0x25100000;
>  
> -				/* Set Base Clock to 208MZ */
> +				/* Set Base Clock to 200MZ */

MZ -> MHz

>  				o2_pci_set_baseclk(chip, scratch_32);
>  				ret = pci_read_config_dword(chip->pdev,
>  							    O2_SD_FUNC_REG4,
> @@ -406,7 +406,7 @@ int sdhci_pci_o2_probe(struct sdhci_pci_chip *chip)
>  					       O2_SD_PLL_SETTING, scratch_32);
>  		} else {
>  			scratch_32 &= 0x0000FFFF;
> -			scratch_32 |= 0x2c280000;
> +			scratch_32 |= 0x25100000;
>  
>  			pci_write_config_dword(chip->pdev,
>  					       O2_SD_PLL_SETTING, scratch_32);
> --
> 2.17.1
> 
> 
> -----éäåä-----
> åää: Adrian Hunter <adrian.hunter@xxxxxxxxx> 
> åéæé: Friday, July 27, 2018 2:58 PM
> æää: Ernest Zhang(WH) <ernest.zhang@xxxxxxxxxxxxxx>; Ulf Hansson <ulf.hansson@xxxxxxxxxx>; linux-mmc@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
> æé: Chuanjin Pang (WH) <chuanjin.pang@xxxxxxxxxxxxxx>; Mike Li (WH) <mike.li@xxxxxxxxxxxxxx>; Chevron Li (WH) <chevron.li@xxxxxxxxxxxxxx>; Shirley Her (SC) <shirley.her@xxxxxxxxxxxxxx>; Xiaoguang Yu (WH) <xiaoguang.yu@xxxxxxxxxxxxxx>; Bobby Wu (WH) <bobby.wu@xxxxxxxxxxxxxx>
> äé: Re: [PATCH V7 2/5] mmc: sdhci: Change O2 Host HS200 mode clock frequency to 200MHz
> 
> On 27/07/18 09:49, Ernest Zhang(WH) wrote:
>> Hi Adrian,
>> 	Do I need re-submit all 5 patches after fix that and change the version to v8?
> 
> You can reply to this email with PATCH V8 2/5 that has my Ack and the comment fixed.
> 
>> BR
>>
>> -----Original Message-----
>> From: Adrian Hunter [mailto:adrian.hunter@xxxxxxxxx]
>> Sent: 2018å7æ25æ 15:45
>> To: Ernest Zhang(WH); Ulf Hansson; linux-mmc@xxxxxxxxxxxxxxx; 
>> linux-kernel@xxxxxxxxxxxxxxx
>> Cc: Chuanjin Pang (WH); Mike Li (WH); Chevron Li (WH); Shirley Her 
>> (SC); Xiaoguang Yu (WH); Bobby Wu (WH)
>> Subject: Re: [PATCH V7 2/5] mmc: sdhci: Change O2 Host HS200 mode 
>> clock frequency to 200MHz
>>
>> On 16/07/18 09:26, ernest.zhang wrote:
>>> O2 SD Host HS200 mode clock frequency current is 208MHz, should be 
>>> changed to 200MHz to meet specification.
>>>
>>> Signed-off-by: ernest.zhang <ernest.zhang@xxxxxxxxxxxxxx>
>>
>> You left in the misleading comment.  Fix that and add:
>>
>> Acked-by: Adrian Hunter <adrian.hunter@xxxxxxxxx>
>>
>>> ---
>>> Change in V7:
>>> 	Change HS200 mode clock frequency from 208MHz to 200MHz to meet
>>> 	Specification.
>>>
>>> Change in V1~V6:
>>> 	N/A
>>> ---
>>>  drivers/mmc/host/sdhci-pci-o2micro.c | 4 ++--
>>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/drivers/mmc/host/sdhci-pci-o2micro.c
>>> b/drivers/mmc/host/sdhci-pci-o2micro.c
>>> index ba59db6a126c..94cf3cd75dd3 100644
>>> --- a/drivers/mmc/host/sdhci-pci-o2micro.c
>>> +++ b/drivers/mmc/host/sdhci-pci-o2micro.c
>>> @@ -311,7 +311,7 @@ int sdhci_pci_o2_probe(struct sdhci_pci_chip
>>> *chip)
>>>  
>>>  			/* Check Whether subId is 0x11 or 0x12 */
>>>  			if ((scratch_32 == 0x11) || (scratch_32 == 0x12)) {
>>> -				scratch_32 = 0x2c280000;
>>> +				scratch_32 = 0x25100000;
>>>  
>>>  				/* Set Base Clock to 208MZ */
>>
>> That comment is misleading now.
>>
>>>  				o2_pci_set_baseclk(chip, scratch_32); @@ -406,7 +406,7 @@ int 
>>> sdhci_pci_o2_probe(struct sdhci_pci_chip *chip)
>>>  					       O2_SD_PLL_SETTING, scratch_32);
>>>  		} else {
>>>  			scratch_32 &= 0x0000FFFF;
>>> -			scratch_32 |= 0x2c280000;
>>> +			scratch_32 |= 0x25100000;
>>>  
>>>  			pci_write_config_dword(chip->pdev,
>>>  					       O2_SD_PLL_SETTING, scratch_32);
>>>
>>
>