Re: [PATCH] fscache: fscache_set_key() - align alloc and usage

From: David Howells
Date: Fri Aug 03 2018 - 09:49:36 EST

Tomas Bortoli <tomasbortoli@xxxxxxxxx> wrote:

> The fscache_set_key() function allocates the buf pointer if index_key_len >
> sizeof(cookie->inline_key). In such cases the allocated space might not be
> aligned with the pointer type. This may result in an out-of-bound in the
> for-loop later in the same function, as the counter is rounded up.

Yeah, it's good idea anyway since I should tell the allocator everything that
I expect to use - though kmalloc() will effectively rounds up the size to a
multiple of 8 anyway (ie. the smallest allocation granule is 8 bytes).