Re: linux-next: Tree for Aug 3 (watchdog/menz69_wdt.c)

[Johannes Thumshirn]

On Fri, Aug 03, 2018 at 08:39:48AM -0700, Randy Dunlap wrote:
> On 08/03/2018 02:29 AM, Stephen Rothwell wrote:
> > Hi all,
> > 
> > Changes since 20180802:
> > 
> 
> Hi,
> 
> On i386 randconfig with COMPILE_TEST=y and MCB not enabled, I see:
> 
> drivers/watchdog/menz69_wdt.o: In function `men_z069_remove':
> menz69_wdt.c:(.text+0xa6): undefined reference to `mcb_release_mem'
> drivers/watchdog/menz69_wdt.o: In function `men_z069_probe':
> menz69_wdt.c:(.text+0xdb): undefined reference to `mcb_request_mem'
> menz69_wdt.c:(.text+0x14a): undefined reference to `mcb_release_mem'
> drivers/watchdog/menz69_wdt.o: In function `men_z069_driver_init':
> menz69_wdt.c:(.init.text+0x15): undefined reference to `__mcb_register_driver'
> drivers/watchdog/menz69_wdt.o: In function `men_z069_driver_exit':
> menz69_wdt.c:(.exit.text+0x9): undefined reference to `mcb_unregister_driver'
> 
> 
> The Kconfig for MENZ069_WATCHDOG says:
> config MENZ069_WATCHDOG
> 	tristate "MEN 16Z069 Watchdog"
> 	depends on MCB || COMPILE_TEST
> 	select WATCHDOG_CORE
> 
> Looks to me like the driver really depends on MCB, unless someone wants
> to add stubs in <linux/mcb.h>.

*doh* looks like a copy & paste error. Wim can you fold that one in
(or stage to your tree)?