Re: [RESEND PATCH] resource: Merge resources on a node when hot-adding memory

[kbuild test robot]

Hi Rashmica,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on linus/master]
[also build test ERROR on v4.18-rc7]
[cannot apply to next-20180802]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Rashmica-Gupta/resource-Merge-resources-on-a-node-when-hot-adding-memory/20180803-221205
config: x86_64-randconfig-x000-201830 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-16) 7.3.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All errors (new ones prefixed by >>):

   mm/memory_hotplug.c: In function 'add_memory':
>> mm/memory_hotplug.c:1191:3: error: implicit declaration of function 'release_mem_region_adjustable'; did you mean 'release_mem_region'? [-Werror=implicit-function-declaration]
      release_mem_region_adjustable(&iomem_resource, start, size);
      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      release_mem_region
   cc1: some warnings being treated as errors

vim +1191 mm/memory_hotplug.c

  1179	
  1180	int __ref add_memory(int nid, u64 start, u64 size)
  1181	{
  1182		struct resource *res;
  1183		int ret;
  1184	
  1185		res = register_memory_resource(nid, start, size);
  1186		if (IS_ERR(res))
  1187			return PTR_ERR(res);
  1188	
  1189		ret = add_memory_resource(nid, start, size, memhp_auto_online);
  1190		if (ret < 0) {
> 1191			release_mem_region_adjustable(&iomem_resource, start, size);
  1192			kfree(res);
  1193		}
  1194		return ret;
  1195	}
  1196	EXPORT_SYMBOL_GPL(add_memory);
  1197	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: application/gzip