Re: [PATCH net-next] ppp: mppe: Remove VLA usage

From: David Miller
Date: Fri Aug 03 2018 - 15:55:17 EST


From: Kees Cook <keescook@xxxxxxxxxxxx>
Date: Fri, 3 Aug 2018 09:37:45 -0700

> In the quest to remove all stack VLA usage from the kernel[1], this
> removes the discouraged use of AHASH_REQUEST_ON_STACK (and associated
> VLA) by switching to shash directly and keeping the associated descriptor
> allocated with the regular state on the heap.
>
> [1] https://lkml.kernel.org/r/CA+55aFzCG-zNmZwX4A2FQpadafLfEzK6CC=qPXydAacU1RqZWA@xxxxxxxxxxxxxx
>
> Signed-off-by: Kees Cook <keescook@xxxxxxxxxxxx>
> Acked-by: Arnd Bergmann <arnd@xxxxxxxx>
> ---
> Paul suggested this go via netdev directly:
> 20180803031315.GA30807@fergus">https://lkml.kernel.org/r/20180803031315.GA30807@fergus

Applied, thanks Kees.