Re: [PATCH] gpu/drm/hisilicon: Convert drm_atomic_helper_suspend/resume()

[Souptick Joarder]

On Fri, Aug 3, 2018 at 12:33 PM, xinliang <z.liuxinliang@xxxxxxxxxxxxx> wrote:
>
>
> On 2018/8/2 17:57, Souptick Joarder wrote:
>>
>> On Thu, Jul 26, 2018 at 1:37 PM, Souptick Joarder<jrdr.linux@xxxxxxxxx>
>> wrote:
>>>
>>> >On Thu, Jul 19, 2018 at 9:34 PM, Souptick Joarder<jrdr.linux@xxxxxxxxx>
>>> > wrote:
>>>>
>>>> >>convert drm_atomic_helper_suspend/resume() to use
>>>> >>drm_mode_config_helper_suspend/resume().
>>>> >>
>>>> >>Fixed one sparse warning by making hibmc_drm_interrupt
>>>> >>static.
>>>> >>
>>>> >>Signed-off-by: Souptick Joarder<jrdr.linux@xxxxxxxxx>
>>>> >>Signed-off-by: Ajit Negi<ajitn.linux@xxxxxxxxx>
>>>> >>---
>>>
>>> >
>>> >Any comment on this patch ?
>>
>> Any review comment for this patch ?
>
> Sorry for late reply. Looks good to me. Thanks.
> Reviewed-by: Xinliang Liu <z.liuxinliang@xxxxxxxxxxxxx>

Xinliang,

I will do little more clean up by removing ret variable from
suspend / resume function and post v2.

>
>