Re: [PATCH v3 2/4] venus: firmware: move load firmware in a separate function

From: Vikash Garodia
Date: Mon Aug 06 2018 - 04:24:56 EST


Hi Stanimir,

On 2018-07-25 15:05, Stanimir Varbanov wrote:
Hi Vikash,

On 07/04/2018 10:06 PM, Vikash Garodia wrote:

<snip>

+
+ if (!IS_ENABLED(CONFIG_QCOM_MDT_LOADER))
+ return -EPROBE_DEFER;

the original venus_boot was checking for || !qcom_scm_is_available() why
is that removed? It was done on purpose.

For booting venus without tz, scm calls are not needed. Does it look good to
keep the check for "!core->no_tz" case alone ?

if (!core->no_tz && !qcom_scm_is_available())
return -EPROBE_DEFER;

Thanks,
Vikash