Re: [PATCH v6 10/18] x86/power/64: Remove VLA usage

From: Rafael J. Wysocki
Date: Mon Aug 06 2018 - 06:30:34 EST


On Wednesday, July 25, 2018 8:01:47 PM CEST Kees Cook wrote:
> On Wed, Jul 25, 2018 at 4:32 AM, Rafael J. Wysocki <rafael@xxxxxxxxxx> wrote:
> > On Tue, Jul 24, 2018 at 6:49 PM, Kees Cook <keescook@xxxxxxxxxxxx> wrote:
> >> In the quest to remove all stack VLA usage from the kernel[1], this
> >> removes the discouraged use of AHASH_REQUEST_ON_STACK by switching to
> >> shash directly and allocating the descriptor in heap memory (which should
> >> be fine: the tfm has already been allocated there too).
> >>
> >> [1] https://lkml.kernel.org/r/CA+55aFzCG-zNmZwX4A2FQpadafLfEzK6CC=qPXydAacU1RqZWA@xxxxxxxxxxxxxx
> >>
> >> Signed-off-by: Kees Cook <keescook@xxxxxxxxxxxx>
> >> Acked-by: Pavel Machek <pavel@xxxxxx>
> >
> > I think I can queue this up if there are no objections from others.
> >
> > Do you want me to do that?
>
> Sure thing. It looks like the other stand-alone patches like this one
> are getting taken into the non-crypto trees, so that's fine.
>

Applied now, thanks!