RE: [PATCH v2] usb: host: xhci-plat: Iterate over parent nodes for finding quirks

[Anurag Kumar Vulisha]

>> -	if (device_property_read_bool(sysdev, "usb3-lpm-capable"))
>> -		xhci->quirks |= XHCI_LPM_SUPPORT;
>> -
>> -	if (device_property_read_bool(&pdev->dev, "quirk-broken-port-ped"))
>> -		xhci->quirks |= XHCI_BROKEN_PORT_PED;
>> -
>>   	/* imod_interval is the interrupt moderation value in nanoseconds. */
>>   	xhci->imod_interval = 40000;
>
>xhci->imod_interval = 40000 is now in the correct place
>
>>   	device_property_read_u32(sysdev, "imod-interval-ns",
>>   				 &xhci->imod_interval);
>
>but the device_propery_read_u32() line above can be moved inside loop below.
>

Hi Mathias,

Thanks for reviewing the patch.  I agree with you, will correct this in v3

Thanks,
Anurag Kumar Vulisha
>>
>> +	/* Iterate over all parent nodes for finding quirks */
>> +	for (tmpdev = &pdev->dev; tmpdev; tmpdev = tmpdev->parent) {
>> +
>> +		if (device_property_read_bool(tmpdev, "usb2-lpm-disable"))
>> +			xhci->quirks |= XHCI_HW_LPM_DISABLE;
>> +
>> +		if (device_property_read_bool(tmpdev, "usb3-lpm-capable"))
>> +			xhci->quirks |= XHCI_LPM_SUPPORT;
>> +
>> +		if (device_property_read_bool(tmpdev, "quirk-broken-port-ped"))
>> +			xhci->quirks |= XHCI_BROKEN_PORT_PED;
>> +	}
>> +
>>   	hcd->usb_phy = devm_usb_get_phy_by_phandle(sysdev, "usb-phy", 0);
>>   	if (IS_ERR(hcd->usb_phy)) {
>>   		ret = PTR_ERR(hcd->usb_phy);
>>
>
>-Mathias