Re: [PATCH v3 4/4] i2c: Add multi-instantiate pseudo driver

From: Andy Shevchenko
Date: Tue Aug 07 2018 - 07:45:24 EST


On Tue, 2018-08-07 at 13:33 +0200, Hans de Goede wrote:
> Hi,
>
> On 07-08-18 13:27, Wolfram Sang wrote:
> > Hi Hans,
> >
> > > +I2C MULTI INSTANTIATE DRIVER

In the case below, I think it would be slightly better to mention ACPI
here, something like

ACPI I2C ...

Otherwise it sounds a bit confusing why it's in PDx86.

> > > +M: Hans de Goede <hdegoede@xxxxxxxxxx>
> > > +L: linux-i2c@xxxxxxxxxxxxxxx
> >
> > Since this driver is about FW bugs, I wonder if
> > platform-driver-x86@xxxxxxxxxxxxxxx isn't the better list here?
>
> Ok, fixed for v4.
>
> > > +S: Maintained
> > > +F: drivers/drivers/platform/x86/i2c-multi-instantiate.c
> >
> > I2C parts of the rest looks good from a glimpse...
>
> Thanks.
>
> Regards,
>
> Hans

--
Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
Intel Finland Oy