Re: [PATCH v12 3/3] tracing: Centralize preemptirq tracepoints and unify their usage

From: Steven Rostedt
Date: Tue Aug 07 2018 - 20:48:35 EST


On Tue, 07 Aug 2018 19:54:13 -0400
Joel Fernandes <joelaf@xxxxxxxxxx> wrote:


> >OK, I hit this bug, but it's not because of the partial revert. This
> >bug seems it needs to be another partial revert. I like you movement of
> >the code, but I'm starting to doubt that we can use a trace event as a
> >hook for critical areas yet. Well, not until we can use srcu in NMI.
> >
>
> I sent a patch to use srcu for all tracepoints including nmi. That
> patch also removes this warning and fixes the one other issue masami
> reported (hot plug causing a warning).

Is it one I can take, or does Paul have it? I'll need it to continue
with this as is, because I can't pass my tests without triggering that
warning (and that fails the test).

>
> If Paul and Mathieu can confirm SRCU works on offline CPUs that would
> be great.

Yes please.

>
> It's just this one warning or anything else that makes you feel
> tracepoints for critical paths isn't feasible?

Currently I'm down to this, but I can't get past my first test in my
ktest suite, because it fails here.

-- Steve