Re: [PATCH 00/15] staging: gasket: unwrap pci core and more

From: Greg Kroah-Hartman
Date: Wed Aug 08 2018 - 05:21:12 EST

On Sun, Aug 05, 2018 at 01:07:34PM -0700, Todd Poynor wrote:
> From: Todd Poynor <toddpoynor@xxxxxxxxxx>
> Stop wrapping PCI core calls like probe, enable, remove, etc. in the
> gasket framework, move these calls to the device driver instead. Have
> gasket drivers call into framework on init, enable, disable,
> etc. sequences, rather than the other way around. Remove the
> gasket-to-device callbacks associated with these sequences.
> Plus a few other fixes and cleanups.
> Todd Poynor (15):
> staging: gasket: sysfs: clean up state if ENOMEM removing mapping
> staging: gasket: core: move core PCI calls to device drivers
> staging: gasket: apex: move PCI core calls to apex driver
> staging: gasket: core: convert remaining info logs to debug
> staging: gasket: core: remove device enable and disable callbacks
> staging: gasket: apex: remove device enable and disable callbacks
> staging: gasket: core: let device driver enable/disable gasket device
> staging: gasket: apex: enable/disable gasket device from apex
> staging: gasket: core: delete device add and remove callbacks
> staging: gasket: apex: fold device add/remove logic inline
> staging: gasket: core: remove sysfs setup and cleanup callbacks
> staging: gasket: apex: move sysfs setup code to probe function
> staging: gasket: core: protect against races during unregister
> staging: gasket: apex: place in low power reset until opened
> staging: gasket: core: remove incorrect extraneous comment
> drivers/staging/gasket/apex_driver.c | 145 +++++++++++++++++---------
> drivers/staging/gasket/gasket_core.c | 140 ++++++-------------------
> drivers/staging/gasket/gasket_core.h | 82 +++------------
> drivers/staging/gasket/gasket_sysfs.c | 13 ++-
> 4 files changed, 148 insertions(+), 232 deletions(-)

Nice cleanups!