Re: [PATCH v3 0/2] PCI: imx: Initial imx7d pm support
From: Lorenzo Pieralisi
Date: Wed Aug 08 2018 - 10:19:49 EST
On Wed, Aug 08, 2018 at 11:37:14AM +0000, Leonard Crestez wrote:
> On Wed, 2018-08-08 at 12:14 +0100, Lorenzo Pieralisi wrote:
> > On Wed, Aug 08, 2018 at 10:53:52AM +0000, Leonard Crestez wrote:
> > > On Tue, 2018-07-24 at 19:14 +0300, Leonard Crestez wrote:
> > > > Changes since v2:
> > > > * Print with dev_info if link fails on resume (Lucas)
> > > > * Add a comment on imx7d pci irq mappings (Andrey)
> > > > * Make imx6_pcie_ltssm_disable print an error on IMX6Q (Lucas)
> > > >
> > > > The ltssm_disable does not return an error because it can't be usefully
> > > > handled, reversing partial suspend is a nightmare and unlikely to work.
> > > >
> > > > * Drop "reset: imx7: Fix always writing bits as 0 (accepted by Philipp)
> > > >
> > > > Series is against linux-next tag next-20180724 where the reset patch was
> > > > already accepted. The imx7d.dtsi patch is also useful standalone.
> > > >
> > > > Link to v2: https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flkml.org%2Flkml%2F2018%2F7%2F20%2F472&data=02%7C01%7Cleonard.crestez%40nxp.com%7Cc1e98512a50246c457a208d5fd2021dc%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C636693236811248777&sdata=gxs1%2BfevIaBmQCVcJLUK41ml8CK2zLg%2FFKGGV%2F%2FHSLQ%3D&reserved=0
> > >
> > > This is a gentle reminder that this series was reviewed by Lucas two
> > > weeks ago but not yet included.
> >
> > Does this series have a functional dependency on the reset fix ? If yes
> > we can have a bisection proplem depending on which tree gets merged
> > first.
>
> Yes, without the reset fix I expect hangs.
>
> Maybe the reset fix should be pulled in the pci tree? I don't know how
> these issues are sorted out.
Well either I pull that fix into the PCI tree (but it is already -rc8
and I can't guarantee v4.19 inclusion - I shall try) or I can ack these
patches and Philippe will send them upstream on my behalf, atop the
reset fix above.
When will the reset fix will be sent to Linus ? Please let me know
how you want to proceed.
Thanks,
Lorenzo