Re: [PATCH 00/11] Add Recon3D support + Driver cleanup

From: Takashi Iwai
Date: Wed Aug 08 2018 - 14:43:27 EST

On Wed, 08 Aug 2018 19:34:11 +0200,
Connor McAdams wrote:
> This patch series adds support for the Recon3D PCI-E card. I have
> personally tested it on a Recon3D that was sent to me, and included
> that PCI ID in the quirk table.
> Much of this patch series renames Recon3Di functions to just r3d
> because both cards behave similarly.

All patches look well cooked. I applied all 11 patches now.

> Aside from that, I do have a question- If the PCI ID's are included in
> the Window's driver .inf file, would I be good to add them in as
> quirks? Or should I wait for someone with the card to test it, and
> then add it once I know it works on that specific card?

Such a decision depends on the situation, and in the case of CA0132,
we can take them, I suppose. The boards don't work properly without
the explicit fixes, so it can't be worse, after all :)