Re: [PATCH v6 5/5] Auto-detect whether a FPU exists

From: Christoph Hellwig
Date: Thu Aug 09 2018 - 04:03:04 EST


On Thu, Aug 09, 2018 at 03:44:40PM +0800, Alan Kao wrote:
> We expect that a kernel with CONFIG_FPU=y can still support no-FPU
> machines. To do so, the kernel should first examine the existence of a
> FPU, then do nothing if a FPU does exist; otherwise, it should
> disable/bypass all FPU-related functions.
>
> In this patch, a new global variable, has_fpu, is created and determined
> when parsing the hardware capability from device tree during booting.
> This variable is used in those FPU-related functions.
>
> Signed-off-by: Alan Kao <alankao@xxxxxxxxxxxxx>
> Cc: Greentime Hu <greentime@xxxxxxxxxxxxx>
> Cc: Vincent Chen <vincentc@xxxxxxxxxxxxx>
> Cc: Zong Li <zong@xxxxxxxxxxxxx>
> Cc: Nick Hu <nickhu@xxxxxxxxxxxxx>

Looks good,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>