Re: [PATCH 07/40] soc/tegra: pmc: Implement tegra_io_pad_is_powered()

From: Thierry Reding
Date: Thu Aug 09 2018 - 08:22:32 EST


On Wed, Aug 01, 2018 at 07:31:57PM +0300, Aapo Vienamo wrote:
> Implement a function to query whether a pad is in deep power down mode.
> This will is needed by the pinctrl callbacks.

"This is needed..."

>
> Signed-off-by: Aapo Vienamo <avienamo@xxxxxxxxxx>
> Acked-by: Jon Hunter <jonathanh@xxxxxxxxxx>
> ---
> drivers/soc/tegra/pmc.c | 16 ++++++++++++++++
> 1 file changed, 16 insertions(+)
>
> diff --git a/drivers/soc/tegra/pmc.c b/drivers/soc/tegra/pmc.c
> index 393ca72..784c182 100644
> --- a/drivers/soc/tegra/pmc.c
> +++ b/drivers/soc/tegra/pmc.c
> @@ -1075,6 +1075,22 @@ int tegra_io_pad_power_disable(enum tegra_io_pad id)
> }
> EXPORT_SYMBOL(tegra_io_pad_power_disable);
>
> +static int tegra_io_pad_is_powered(enum tegra_io_pad id)
> +{
> + unsigned long request, status;
> + u32 mask;
> + u32 value;

These can go on a single line.

Thierry

Attachment: signature.asc
Description: PGP signature