Re: [PATCH] perf probe powerpc: Fix trace event post-processing

From: Arnaldo Carvalho de Melo
Date: Thu Aug 09 2018 - 13:46:32 EST


Em Thu, Aug 09, 2018 at 09:56:24PM +0530, Naveen N. Rao escreveu:
> Sandipan Das wrote:
<SNIP>
> > This can be verified on a powerpc64le system as shown below.
<SNIP>
> > Before:
> > # perf probe -v -a sys_open
<SNIP>
> > # perf probe -v -a sys_open%return $retval
<SNIP>
> > Failed to write event: Invalid argument
> > Error: Failed to add events. Reason: Invalid argument (Code: -22)
> > After:
> > # perf probe -v -a sys_open
<SNIP>
> > Writing event: p:probe/sys_open _text+4276888
> > Added new event:
> > probe:sys_open (on sys_open)
> > ...
> >
> > # perf probe -v -a sys_open%return $retval
<SNIP>
> > Writing event: r:probe/sys_open__return _text+4276888
> > Added new event:
> > probe:sys_open__return (on sys_open%return)
> > Fixes: 99e608b5954c ("perf probe ppc64le: Fix probe location when using DWARF")
> > Reported-by: Aneesh Kumar K.V <aneesh.kumar@xxxxxxxxxxxxxxxxxx>
> > Signed-off-by: Sandipan Das <sandipan@xxxxxxxxxxxxx>

> Acked-by: Naveen N. Rao <naveen.n.rao@xxxxxxxxxxxxxxxxxx>

Thanks, applied!

Excellent commit log message, btw, keep it up.

- arnaldo