Re: [PATCH v8 1/4] PCI: Make specifying PCI devices in kernel parameters reusable

[Logan Gunthorpe]

On 09/08/18 03:15 PM, Bjorn Helgaas wrote:
>> @@ -2994,7 +2994,26 @@
>>  			See header of drivers/block/paride/pcd.c.
>>  			See also Documentation/blockdev/paride.txt.
>>  
>> -	pci=option[,option...]	[PCI] various PCI subsystem options:
>> +	pci=option[,option...]	[PCI] various PCI subsystem options.
>> +
>> +				Some options herein operate on a specific device
>> +				or a set of devices (<pci_dev>). These are
>> +				specified in one of the following formats:
>> +
>> +				[<domain>:]<bus>:<slot>.<func>
>> +				pci:<vendor>:<device>[:<subvendor>:<subdevice>]
>> +
>> +				Note: the first format specifies a PCI
>> +				bus/slot/function address which may change
> 
> Unless you object, I'm going to change "slot" references like this to
> "device" so they match "BDF" and the language in the spec, which uses
> "slot" to refer to a physical slot and "device" when referring to
> geographical device addresses.  I can do this when I apply these, so
> no need for you to repost them.

No objection. I never liked the "slot" reference but was trying to
remain consistent with what was there before. If I remember correctly
there's a bunch of places in the kernel that use slot as well.

Thanks,

Logan