Re: [PATCH v8 0/4] Add parameter for disabling ACS redirection for P2P

From: Bjorn Helgaas
Date: Thu Aug 09 2018 - 19:03:39 EST


On Mon, Jul 30, 2018 at 10:18:36AM -0600, Logan Gunthorpe wrote:
> Changes since v6:
> * Fixed order of operations for device specific disable function as
> noticed by Alex
> * Rebased onto v4.18-rc5 (no conflicts)
>
> Changes since v5:
> * Add a quirk to handle the Intel SPT PCH case (as pointed out by Alex)
> * Warn in the case that we try to disable ACS redirect on a device
> that doesn't have the ACS capability (also suggested by Alex)
> * Collect reviewed-by tag from Alex
> * Rebased onto v4.18-rc4 (no conflicts)
>
> Changes since v4:
> * Fixed a couple documentation mistakes spotted by Randy
>
> Changes since v3:
> * Removed some of the cruft that was copied from the resource_alignment
> paramater (per Alex)
> * A number of docuemntation fixes as noticed by Alex and Willy
>
> Changes since v2:
> * Rebased onto v4.18-rc1 (no conflicts)
> * Minor tweaks to the documentation per Andy
> * Removed the "path:" prefix and use the path parsing code
> for simple devices (as it works the same). Per a suggestion from Alex
>
> Changes since v1:
> * Reworked pci_dev_str_match_path using strrchr as suggested by Alex
> * Collected Christian's Acks
>
>
> Logan Gunthorpe (4):
> PCI: Make specifying PCI devices in kernel parameters reusable
> PCI: Allow specifying devices using a base bus and path of devfns
> PCI: Introduce disable_acs_redir quirk
> PCI: Introduce the disable_acs_redir parameter
>
> Documentation/admin-guide/kernel-parameters.txt | 41 +++-
> drivers/pci/pci.c | 310 +++++++++++++++++++-----
> drivers/pci/quirks.c | 78 +++++-
> include/linux/pci.h | 5 +
> 4 files changed, 361 insertions(+), 73 deletions(-)

I reorganized this a bit and split the quirk code into a couple
patches an put the result on my pci/peer-to-peer branch for v4.19.

I think the result is equivalent, but let me know if I made a mistake.

Bjorn