Re: [Xen-devel] [PATCH 04/10] x86/paravirt: use a single ops structure

From: Jan Beulich
Date: Fri Aug 10 2018 - 08:06:17 EST

Next message: Beijing Shougang Company Ltd: "Our Company Beijing Shougang Company Ltd.,based in China is in search of a competent individual or firm that will beresponsible in handling funds as our ''Representative Manager'' in theUnited States/Canada region.If interested kindly email our Human ResourcesDepartment via { info.beijingshougang@xxxxxxxxxxx } for more description ofthe job, compensations and monthly salary involved."
Previous message: Kalle Valo: "Re: [PATCH 1/1] ath10k: avoid possible memory access violation"
In reply to: Juergen Gross: "[PATCH 04/10] x86/paravirt: use a single ops structure"
Next in thread: Juergen Gross: "Re: [Xen-devel] [PATCH 04/10] x86/paravirt: use a single ops structure"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

>>> On 10.08.18 at 13:52, <jgross@xxxxxxxx> wrote:
> --- a/arch/x86/hyperv/mmu.c
> +++ b/arch/x86/hyperv/mmu.c
> @@ -228,9 +228,9 @@ void hyperv_setup_mmu_ops(void)
>
> if (!(ms_hyperv.hints & HV_X64_EX_PROCESSOR_MASKS_RECOMMENDED)) {
> pr_info("Using hypercall for remote TLB flush\n");
> - pv_mmu_ops.flush_tlb_others = hyperv_flush_tlb_others;
> + pv_ops.pv_mmu_ops.flush_tlb_others = hyperv_flush_tlb_others;

Taking just this as example, why not

pv_ops.mmu.flush_tlb_others = hyperv_flush_tlb_others;

? Both pv_ and _ops are redundant on the field names.

Jan