Re: [PATCH v8 09/26] kernel/cpu_pm: Manage runtime PM in the idle path for CPUs
From: Lina Iyer
Date: Fri Aug 10 2018 - 16:18:22 EST
On Thu, Aug 09 2018 at 04:25 -0600, Lorenzo Pieralisi wrote:
On Wed, Aug 08, 2018 at 12:02:48PM -0600, Lina Iyer wrote:
On Wed, Aug 08 2018 at 04:56 -0600, Lorenzo Pieralisi wrote:
>On Mon, Aug 06, 2018 at 11:37:55AM +0200, Rafael J. Wysocki wrote:
>>On Fri, Aug 3, 2018 at 1:42 PM, Ulf Hansson <ulf.hansson@xxxxxxxxxx> wrote:
>>> [...]
>>>
>>>>>
>>>>> Assuming that I have got that right, there are concerns, mostly regarding
>>>>> patch [07/26], but I will reply to that directly.
>>>>
>>>> Well, I haven't got that right, so never mind.
>>>>
>>>> There are a few minor things to address, but apart from that the general
>>>> genpd patches look ready.
>>>
>>> Alright, thanks!
>>>
>>> I will re-spin the series and post a new version once 4.19 rc1 is out.
>>> Hopefully we can queue it up early in next cycle to get it tested in
>>> next for a while.
>>>
>>>>
>>>>> The $subject patch is fine by me by itself, but it obviously depends on the
>>>>> previous ones. Patches [01-02/26] are fine too, but they don't seem to be
>>>>> particularly useful without the rest of the series.
>>>>>
>>>>> As far as patches [10-26/26] go, I'd like to see some review comments and/or
>>>>> tags from the people with vested interest in there, in particular from Daniel
>>>>> on patch [12/26] and from Sudeep on the PSCI ones.
>>>>
>>>> But this still holds.
>>>
>>> Actually, patch 10 and patch11 is ready to go as well. I ping Daniel
>>> on patch 12.
>>>
>>> In regards to the rest of the series, some of the PSCI/ARM changes
>>> have been reviewed by Mark Rutland, however several changes have not
>>> been acked.
>>>
>>> On the other hand, one can also interpret the long silence in regards
>>> to PSCI/ARM changes as they are good to go. :-)
>>
>>Well, in that case giving an ACK to them should not be an issue for
>>the people with a vested interest I suppose.
>
>Apologies to everyone for the delay in replying.
>
>Side note: cpu_pm_enter()/exit() are also called through syscore ops in
>s2RAM/IDLE, you know that but I just wanted to mention it to compound
>the discussion.
>
>As for PSCI patches I do not personally think PSCI OSI enablement is
>beneficial (and my position has always been the same since PSCI OSI was
>added to the specification, I am not even talking about this patchset)
>and Arm Trusted Firmware does not currently support it for the same
>reason.
>
>We (if Mark and Sudeep agree) will enable PSCI OSI if and when we have a
>definitive and constructive answer to *why* we have to do that that is
>not a dogmatic "the kernel knows better" but rather a comprehensive
>power benchmark evaluation - I thought that was the agreement reached
>at OSPM but apparently I was mistaken.
>
I will not speak to any comparison of benchmarks between OSI and PC.
AFAIK, there are no platforms supporting both.
PSCI specifications, 5.20.1:
"The platform will boot in platform-coordinated mode."
So all platforms implementing OSI have to support both.
I understand. But there are no actual platforms out there that support
both. QC platforms do not support Platform coordinated in the firmware.
The primary reason for not doing PC is that it did not fit the
requirements for all high level OSes running on the AP. Also, having
dead code in a firmware that also does secure aspects was not desirable
for QC platforms. That said, the decision to not do PC is beyond my pay
grade.
But, the OSI feature is critical for QCOM mobile platforms. The
last man activities during cpuidle save quite a lot of power.
What I expressed above was that, in PSCI based systems (OSI or PC
alike), it is up to firmware/hardware to detect "the last man" not
the kernel.
I need to understand what you mean by "last man activities" to
provide feedback here.
When the last CPU goes down during deep sleep, the following would be
done
- Lower resource requirements for shared resources such as clocks,
busses and regulators that were used by drivers in AP. These shared
resources when not used by other processors in the SoC may be turned
off and put in low power state by a remote processor. [1][2]
- Enable and setup wakeup capable interrupts on an always-on interrupt
controller, so the GIC and the GPIO controllers may be put in low
power state. [3][4]
- Write next known wakeup value to the timer, so the blocks that were
powered off, may be brought back into operational before the wakeup.
[4][5]
These are commonly done during suspend, but to achieve a good power
efficiency, we have to do this when all the CPUs are just executing CPU
idle. Also, they cannot be done from the firmware (because the data
required for all this is part of Linux). OSI plays a crucial role in
determining when to do all this.
Powering off the clocks, busses, regulators and even the oscillator is
very important to have a reasonable battery life when using the phone.
Platform coordinated approach falls quite short of the needs of a
powerful processor with a desired battery efficiency.
I am sorry but if you want us to merge PSCI patches in this series you
will have to back the claim above with a detailed technical explanation
of *why* platform-coordination falls short of QCOM (or whoever else)
needs wrt PSCI OSI.
These items above add much value to reduce latency in wakeup idle,
increase cache performance and increase days of use. Even if we had a
platform to test for platform coordinated, it would be hard to quantify
because of the inability to do low power state for resources and setting
up wakeup is not easily possible with platform coordinated. Not doing
it, would leave a lot of power efficiency and performance on the table.
Thanks,
Lina
[1]. https://lkml.org/lkml/2018/6/11/546
[2]. For older production code -
https://source.codeaurora.org/quic/la/kernel/msm-4.4/tree/drivers/soc/qcom/rpm-smd.c?h=LA.HB.1.1.5.c1
Line 1764.
[3]. https://lkml.org/lkml/2018/8/10/437
[4]. Older production code -
https://source.codeaurora.org/quic/la/kernel/msm-4.4/tree/drivers/soc/qcom/mpm-of.c?h=LA.HB.1.1.5.c1
[5]. https://lkml.org/lkml/2018/7/19/218