Re: [PATCH v8 3/6] Uprobes: Support SDT markers having reference count (semaphore)

From: Song Liu
Date: Sat Aug 11 2018 - 02:14:26 EST


On Fri, Aug 10, 2018 at 12:58 PM, Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:
> On Thu, 9 Aug 2018 16:38:28 +0200
> Oleg Nesterov <oleg@xxxxxxxxxx> wrote:
>
>> I need to read this (hopefully final) version carefully. I'll try to do
>> this before next Monday.
>>
>
> Monday may be the opening of the merge window (more likely Sunday). Do
> you think this is good enough for pushing it in this late in the game,
> or do you think we should wait another cycle?
>
> -- Steve

We (Facebook) have use cases in production that would benefit from this work, so
I would rather see this gets in sooner than later. After a brief
review (I will more
careful review before Monday), I think this set is not likely to break
existing uprobes
(those w/o ref_ctr). Therefore, I think it is safe to put it in this cycle.

Thanks,
Song