Re: [PATCH] staging: netlogic: Fixed comments to include SPDX-License-Identifier

From: Greg KH
Date: Sat Aug 11 2018 - 12:26:12 EST


On Sat, Aug 11, 2018 at 06:15:05PM +0200, Michael Anckaert wrote:
> This patch fixes some issues with missing SPDX-License-Identifier
> comments.
>
> Disclaimer: this is my first patch and instructions were taken from the
> KernelNewbies project.

This does not belong in a changelog comment. If you want to put info
like this, put it below the --- line.

>
> Signed-off-by: Michael Anckaert <michael.anckaert@xxxxxxxx>
> ---
> drivers/staging/netlogic/Kconfig | 6 +++---
> drivers/staging/netlogic/platform_net.c | 1 +
> drivers/staging/netlogic/platform_net.h | 1 +
> drivers/staging/netlogic/xlr_net.c | 1 +
> drivers/staging/netlogic/xlr_net.h | 1 +
> 5 files changed, 7 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/netlogic/Kconfig b/drivers/staging/netlogic/Kconfig
> index d660de51b541..ab0b756bc08b 100644
> --- a/drivers/staging/netlogic/Kconfig
> +++ b/drivers/staging/netlogic/Kconfig
> @@ -2,6 +2,6 @@ config NETLOGIC_XLR_NET
> tristate "Netlogic XLR/XLS network device"
> depends on CPU_XLR
> select PHYLIB
> - ---help---
> - This driver support Netlogic XLR/XLS on chip gigabit
> - Ethernet.
> + help
> + This driver support Netlogic XLR/XLS on chip gigabit
> + Ethernet.

This change has nothing to do with spdx identifiers :(

Please fix up and resend as 2 different patches.

thanks,

greg k-h