Re: [PATCH] drivers/net/usb/r8152: change rtl8152_system_suspend to be void function

[Dan Carpenter]

Hi zhong,

Thank you for the patch! Perhaps something to improve:

url:    https://github.com/0day-ci/linux/commits/zhong-jiang/drivers-net-usb-r8152-change-rtl8152_system_suspend-to-be-void-function/20180809-111737

New smatch warnings:
drivers/net/usb/r8152.c:4447 rtl8152_suspend() error: uninitialized symbol 'ret'.

Old smatch warnings:
drivers/net/usb/r8152.c:4660 rtl8152_get_strings() error: memcpy() '*rtl8152_gstrings' too small (32 vs 416)

# https://github.com/0day-ci/linux/commit/31b61d6a0989c067332fa1ae07055b3e406c17cd
git remote add linux-review https://github.com/0day-ci/linux
git remote update linux-review
git checkout 31b61d6a0989c067332fa1ae07055b3e406c17cd
vim +/ret +4447 drivers/net/usb/r8152.c

8fb280616 hayeswang   2017-01-10  4432  
8fb280616 hayeswang   2017-01-10  4433  static int rtl8152_suspend(struct usb_interface *intf, pm_message_t message)
8fb280616 hayeswang   2017-01-10  4434  {
8fb280616 hayeswang   2017-01-10  4435  	struct r8152 *tp = usb_get_intfdata(intf);
8fb280616 hayeswang   2017-01-10  4436  	int ret;
8fb280616 hayeswang   2017-01-10  4437  
8fb280616 hayeswang   2017-01-10  4438  	mutex_lock(&tp->control);
8fb280616 hayeswang   2017-01-10  4439  
8fb280616 hayeswang   2017-01-10  4440  	if (PMSG_IS_AUTO(message))
a9c54ad2c hayeswang   2017-01-25  4441  		ret = rtl8152_runtime_suspend(tp);
8fb280616 hayeswang   2017-01-10  4442  	else
31b61d6a0 zhong jiang 2018-08-08  4443  		rtl8152_system_suspend(tp);
8fb280616 hayeswang   2017-01-10  4444  
b54032736 hayeswang   2014-10-09  4445  	mutex_unlock(&tp->control);
b54032736 hayeswang   2014-10-09  4446  
6cc69f2a4 hayeswang   2014-10-17 @4447  	return ret;
ac718b693 hayeswang   2013-05-02  4448  }
ac718b693 hayeswang   2013-05-02  4449  

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation