Re: [PATCH 1/3] dts: arm64/sdm845: Add node for arm,mmu-500

[Vivek Gautam]

Hi Doug,


On 8/11/2018 4:00 AM, Doug Anderson wrote:
> Hi,
>
> On Fri, Aug 10, 2018 at 3:18 PM, Doug Anderson <dianders@xxxxxxxxxxxx> wrote:
> > Hi,
> >
> > On Thu, Jul 19, 2018 at 10:53 AM, Vivek Gautam
> > <vivek.gautam@xxxxxxxxxxxxxx> wrote:
> > > Add device node for arm,mmu-500 available on sdm845.
> > > This MMU-500 with single TCU and multiple TBU architecture
> > > is shared among all the peripherals except gpu on sdm845.
> > >
> > > Signed-off-by: Vivek Gautam <vivek.gautam@xxxxxxxxxxxxxx>
> > > ---
> > >   arch/arm64/boot/dts/qcom/sdm845-mtp.dts |  4 ++
> > >   arch/arm64/boot/dts/qcom/sdm845.dtsi    | 73 +++++++++++++++++++++++++++++++++
> > >   2 files changed, 77 insertions(+)
> > >
> > > diff --git a/arch/arm64/boot/dts/qcom/sdm845-mtp.dts b/arch/arm64/boot/dts/qcom/sdm845-mtp.dts
> > > index 6d651f314193..13b50dff440f 100644
> > > --- a/arch/arm64/boot/dts/qcom/sdm845-mtp.dts
> > > +++ b/arch/arm64/boot/dts/qcom/sdm845-mtp.dts
> > > @@ -58,3 +58,7 @@
> > >                  bias-pull-up;
> > >          };
> > >   };
> > > +
> > > +&apps_smmu {
> > > +       status = "okay";
> > > +};
> > When you spin this patch please put the above in the correct place.
> > Since "a" sorts alphabetically before "i" then this should be just
> > before the line:
> >
> > &i2c10 {
> Sorry--one more thing I thought of after I sent this out...
>
> Possibly you can drop this part of the patch completely and get rid of
> the 'status = "disabled";' in sdm845.dtsi.  As I understand it you
> really only want to mark things as disabled in the SoC dtsi file if
> some boards might use this device and other boards wouldn't.  For
> instance not all boards will have the SD card controller hooked up /
> enabled so having that set to "disabled" in the SoC device tree file
> makes sense.  ...but it's not a board-level question about whether the
> SMMU is present--it's always there.  You don't gain anything by
> forcing all boards to set status to "okay".

Thanks for reviewing the patches.
Will sort the node as per alphabetical order.
Also as you pointed, it makes sense to not have the 'status' property
in SMMU. Will remove that. Thanks.

Best regards
Vivek
> -Doug