Re: [PATCH net-next] liquidio: remove set but not used variable 'is25G'

[YueHaibing]

On 2018/8/13 17:08, Shaikh, Shahed wrote:
>> -----Original Message-----
>> From: netdev-owner@xxxxxxxxxxxxxxx <netdev-owner@xxxxxxxxxxxxxxx> On
>> Behalf Of YueHaibing
>> Sent: Monday, August 13, 2018 12:51 PM
>> To: davem@xxxxxxxxxxxxx; Chickles, Derek <Derek.Chickles@xxxxxxxxxx>;
>> Burla, Satananda <Satananda.Burla@xxxxxxxxxx>; Manlunas, Felix
>> <Felix.Manlunas@xxxxxxxxxx>; Vatsavayi, Raghu
>> <Raghu.Vatsavayi@xxxxxxxxxx>
>> Cc: linux-kernel@xxxxxxxxxxxxxxx; netdev@xxxxxxxxxxxxxxx; YueHaibing
>> <yuehaibing@xxxxxxxxxx>
>> Subject: [PATCH net-next] liquidio: remove set but not used variable 'is25G'
>>
>> External Email
>>
>> Fixes gcc '-Wunused-but-set-variable' warning:
>>
>> drivers/net/ethernet/cavium/liquidio/lio_ethtool.c: In function
>> 'lio_set_link_ksettings':
>> drivers/net/ethernet/cavium/liquidio/lio_ethtool.c:392:6: warning:
>>  variable 'is25G' set but not used [-Wunused-but-set-variable]
>>
>> Signed-off-by: YueHaibing <yuehaibing@xxxxxxxxxx>
>> ---
>>  drivers/net/ethernet/cavium/liquidio/lio_ethtool.c | 7 ++-----
>>  1 file changed, 2 insertions(+), 5 deletions(-)
>>
>> diff --git a/drivers/net/ethernet/cavium/liquidio/lio_ethtool.c
>> b/drivers/net/ethernet/cavium/liquidio/lio_ethtool.c
>> index 807ea2c..5ce604a 100644
>> --- a/drivers/net/ethernet/cavium/liquidio/lio_ethtool.c
>> +++ b/drivers/net/ethernet/cavium/liquidio/lio_ethtool.c
>> @@ -389,16 +389,13 @@ static int lio_set_link_ksettings(struct net_device
>> *netdev,
>>         struct lio *lio = GET_LIO(netdev);
>>         struct oct_link_info *linfo;
>>         struct octeon_device *oct;
>> -       u32 is25G = 0;
>>
>>         oct = lio->oct_dev;
>>
>>         linfo = &lio->linfo;
>>
>> -       if (oct->subsystem_id == OCTEON_CN2350_25GB_SUBSYS_ID ||
>> -           oct->subsystem_id == OCTEON_CN2360_25GB_SUBSYS_ID) {
>> -               is25G = 1;
>> -       } else {
>> +       if (!(oct->subsystem_id == OCTEON_CN2350_25GB_SUBSYS_ID ||
>> +             oct->subsystem_id == OCTEON_CN2360_25GB_SUBSYS_ID)) {
>>                 return -EOPNOTSUPP;
>>         }
> 
> You can also remove braces which are not required for single line.

Yes, thanks.  Will post v2

> Thanks,
> Shahed
> 
> 
>