Re: [PATCH] Support mksh as /bin/sh.

[Kees Cook]

On Mon, Aug 13, 2018 at 3:14 AM,  <arekm@xxxxxxxx> wrote:
> From: Arkadiusz MiÅkiewicz <arekm@xxxxxxxx>
>
> mksh needs space between ! and ( to work properly. Otherwise this
> happens:
>
> + make oldconfig
> scripts/kconfig/conf  --oldconfig Kconfig
> ./scripts/clang-version.sh[18]: COPYING: not found
> printf: â__clang_major__â: expected a numeric value
> printf: â__clang_minor__â: expected a numeric value
> printf: â__clang_patchlevel__â: expected a numeric value
> init/Kconfig:24:warning: 'CLANG_VERSION': number is invalid
>
> Signed-off-by: Arkadiusz MiÅkiewicz <arekm@xxxxxxxx>

Reviewed-by: Kees Cook <keescook@xxxxxxxxxxxx>

-Kees

> ---
>  scripts/clang-version.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/clang-version.sh b/scripts/clang-version.sh
> index dbf0a31eb111..e65fbc3079d4 100755
> --- a/scripts/clang-version.sh
> +++ b/scripts/clang-version.sh
> @@ -12,7 +12,7 @@
>
>  compiler="$*"
>
> -if !( $compiler --version | grep -q clang) ; then
> +if ! ( $compiler --version | grep -q clang) ; then
>         echo 0
>         exit 1
>  fi
> --
> 2.18.0
>



-- 
Kees Cook
Pixel Security