Re: [PATCH 1/2] perf tools: Make check-headers.sh check based on kernel dir

From: Michael Ellerman
Date: Tue Aug 14 2018 - 09:27:06 EST


Jiri Olsa <jolsa@xxxxxxxxxx> writes:
> diff --git a/tools/perf/check-headers.sh b/tools/perf/check-headers.sh
> index ea48aa6f8d19..9d466e853aec 100755
> --- a/tools/perf/check-headers.sh
> +++ b/tools/perf/check-headers.sh
> @@ -88,6 +88,8 @@ check () {
> # differences.
> test -d ../../include || exit 0
>
> +pushd ../.. > /dev/null
> +
> # simple diff check
> for i in $HEADERS; do
> check $i -B

This breaks the build when sh is not bash:

./check-headers.sh: 91: ./check-headers.sh: pushd: not found
./check-headers.sh: 107: ./check-headers.sh: popd: not found
Makefile.perf:205: recipe for target 'sub-make' failed

cheers