Re: [PATCH v2 3/5] watchdog: hpwdt: Display module parameters.

[Guenter Roeck]

On 08/08/2018 12:13 PM, Jerry Hoemann wrote:
> Print module parameters when the driver is loaded.
>
> Signed-off-by: Jerry Hoemann <jerry.hoemann@xxxxxxx>

Reviewed-by: Guenter Roeck <linux@xxxxxxxxxxxx>

> ---
>   drivers/watchdog/hpwdt.c | 9 ++++++---
>   1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/watchdog/hpwdt.c b/drivers/watchdog/hpwdt.c
> index bb41714..69a88b1 100644
> --- a/drivers/watchdog/hpwdt.c
> +++ b/drivers/watchdog/hpwdt.c
> @@ -320,9 +320,12 @@ static int hpwdt_init_one(struct pci_dev *dev,
>   		goto error_wd_register;
>   	}
>   
> -	dev_info(&dev->dev, "HPE Watchdog Timer Driver: %s"
> -			", timer margin: %d seconds (nowayout=%d).\n",
> -			HPWDT_VERSION, hpwdt_dev.timeout, nowayout);
> +	dev_info(&dev->dev, "HPE Watchdog Timer Driver: Version: %s\n",
> +				HPWDT_VERSION);
> +	dev_info(&dev->dev, "timeout: %d seconds (nowayout=%d)\n",
> +				hpwdt_dev.timeout, nowayout);
> +	dev_info(&dev->dev, "pretimeout: %s.\n",
> +				pretimeout ? "on" : "off");
>   
>   	if (dev->subsystem_vendor == PCI_VENDOR_ID_HP_3PAR)
>   		ilo5 = true;