Re: [PATCH] spi:fix IDR collision on systems with both fixed and dynamic SPI bus numbers

[Mark Brown]

On Mon, Aug 13, 2018 at 07:48:10PM +0300, Kirill Kapranov wrote:
> On systems where some controllers get a dynamic ID assigned and some have
> a fixed number (e.g. from ACPI tables), the current implementation might
> run into an IDR collision: in case of a fixed bus number is gotten by a
> driver (but not marked busy in IDR tree) and a driver with dynamic bus
> number gets the same ID and predictably fails.

Is this something that's actually happened for you?

> +	} else {
> +	/* devices with a fixed bus num must check-in with the num */
> +		mutex_lock(&board_lock);

The indentation here is weird, the comment isn't aligned with the code
it's commenting on.

Attachment: signature.asc
Description: PGP signature