Re: [PATCH] usb: hide usb_of_get_companion_dev for CONFIG_USB=n

From: Arnd Bergmann
Date: Tue Aug 14 2018 - 10:26:50 EST


On Tue, Aug 14, 2018 at 3:58 PM Alan Stern <stern@xxxxxxxxxxxxxxxxxxx> wrote:
> On Mon, 13 Aug 2018, Arnd Bergmann wrote:
> > diff --git a/drivers/usb/gadget/udc/Kconfig b/drivers/usb/gadget/udc/Kconfig
> > index 0a16cbd4e528..663a8bd67a7b 100644
> > --- a/drivers/usb/gadget/udc/Kconfig
> > +++ b/drivers/usb/gadget/udc/Kconfig
> > @@ -193,6 +193,7 @@ config USB_RENESAS_USB3
> > tristate 'Renesas USB3.0 Peripheral controller'
> > depends on ARCH_RENESAS || COMPILE_TEST
> > depends on EXTCON
> > + depends on USB || !USB
>
> Is this some weird standard idiom? It looks really strange.

Yes, and yes.

A less common way to write it is

depends on (USB != m) || m

which some people prefer, but I find even weirder.

Arnd