Re: [PATCH v1 00/22] LSM: Full security module stacking

From: Sargun Dhillon
Date: Tue Aug 14 2018 - 13:05:51 EST

On Mon, Jul 16, 2018 at 10:53 AM, Casey Schaufler
<casey@xxxxxxxxxxxxxxxx> wrote:
> LSM: Full security module stacking
> I'm calling this v1 not because it's the first version
> I've put out but because it's the first version I'm getting
> serious external pressure to get upstream.
Awesome work, I'm glad that this is getting further.

> The blob management part (through "LSM: Sharing of security blobs")
> is ready for prime-time. These changes move the management of
> security blobs out of the security modules and into the security
> module infrastructure. With this change the proposed S.A.R.A,
> LandLock and PTAGS security modules could co-exist with any of
> the existing "major" security modules. The changes reduce some
> code duplication.
> Beyond the blob management there's a bit of clean-up.
> Mounting filesystems had to be changed so that options
> a security module doesn't recognize won't be considered
> a fatal error. The mount infrastructure is somewhat
> more complex than one might assume.

Do you think you can break out 1 into its own patch? It seems like
that'd be valuable to everyone.

What's your thought here if we ever introduce dynamic security
modules? It's nice that we now have a way around rolling back blobs if
one fails, but what if a new module was activated, would we just
resize the slab cache?