Re: [PATCH] perf auxtrace: Fix queue resize

From: Arnaldo Carvalho de Melo
Date: Tue Aug 14 2018 - 18:07:50 EST


Em Tue, Aug 14, 2018 at 11:46:08AM +0300, Adrian Hunter escreveu:
> When the number of queues grows beyond 32, the array of queues is resized
> but not all members were being copied. Fix by also copying 'tid', 'cpu' and
> 'set'.

Thanks, applied.

> Fixes: e502789302a6e ("perf auxtrace: Add helpers for queuing AUX area tracing data")
> Cc: stable@xxxxxxxxxxxxxxx
> Signed-off-by: Adrian Hunter <adrian.hunter@xxxxxxxxx>
> ---
> tools/perf/util/auxtrace.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/tools/perf/util/auxtrace.c b/tools/perf/util/auxtrace.c
> index ae8c37b219c9..db1511359c5e 100644
> --- a/tools/perf/util/auxtrace.c
> +++ b/tools/perf/util/auxtrace.c
> @@ -203,6 +203,9 @@ static int auxtrace_queues__grow(struct auxtrace_queues *queues,
> for (i = 0; i < queues->nr_queues; i++) {
> list_splice_tail(&queues->queue_array[i].head,
> &queue_array[i].head);
> + queue_array[i].tid = queues->queue_array[i].tid;
> + queue_array[i].cpu = queues->queue_array[i].cpu;
> + queue_array[i].set = queues->queue_array[i].set;
> queue_array[i].priv = queues->queue_array[i].priv;
> }
>
> --
> 2.17.1