Re: [PATCH] platform/x86: asus-wmi: Add keymap entry for lid flip action on Asus UX360

[Andy Shevchenko]

On Fri, Aug 10, 2018 at 11:07 PM, Aleh Filipovich <aleh@xxxxxxxxxx> wrote:
> Add entry to WMI keymap for lid flip event on Asus UX360.
>
> On Asus Zenbook ux360 flipping lid from/to tablet mode triggers
> keyscan code 0xfa which cannot be handled and results in kernel
> log message "Unknown key fa pressed".
>
>

Pushed to my review and testing queue, thanks!

P.S. your patch is mangled, please, pay attention to the format next time.

> Signed-off-by: Aleh Filipovich<aleh@xxxxxxxxxxxx>
> ---
>  drivers/platform/x86/asus-nb-wmi.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/platform/x86/asus-nb-wmi.c
> b/drivers/platform/x86/asus-nb-wmi.c
> index 136ff2b4cce5..db2af09067db 100644
> --- a/drivers/platform/x86/asus-nb-wmi.c
> +++ b/drivers/platform/x86/asus-nb-wmi.c
> @@ -496,6 +496,7 @@ static const struct key_entry asus_nb_wmi_keymap[] = {
>         { KE_KEY, 0xC4, { KEY_KBDILLUMUP } },
>         { KE_KEY, 0xC5, { KEY_KBDILLUMDOWN } },
>         { KE_IGNORE, 0xC6, },  /* Ambient Light Sensor notification */
> +       { KE_KEY, 0xFA, { KEY_PROG2 } },           /* Lid flip action */
>         { KE_END, 0},
>  };
>
> --
> 2.18.0
>



-- 
With Best Regards,
Andy Shevchenko