Re: [PATCH] kdb: kdb_keyboard: mark expected switch fall-throughs

[Daniel Thompson]

On 05/08/18 05:18, Gustavo A. R. Silva wrote:
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
>
> Notice that in this particular case, I replaced the code comments with
> a proper "fall through" annotation, which is what GCC is expecting
> to find.
>
> Signed-off-by: Gustavo A. R. Silva <gustavo@xxxxxxxxxxxxxx>

Reviewed-by: Daniel Thompson <daniel.thompson@xxxxxxxxxx>

> ---
>   kernel/debug/kdb/kdb_keyboard.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/kernel/debug/kdb/kdb_keyboard.c b/kernel/debug/kdb/kdb_keyboard.c
> index 118527a..750497b 100644
> --- a/kernel/debug/kdb/kdb_keyboard.c
> +++ b/kernel/debug/kdb/kdb_keyboard.c
> @@ -173,11 +173,11 @@ int kdb_get_kbd_char(void)
>   	case KT_LATIN:
>   		if (isprint(keychar))
>   			break;		/* printable characters */
> -		/* drop through */
> +		/* fall through */
>   	case KT_SPEC:
>   		if (keychar == K_ENTER)
>   			break;
> -		/* drop through */
> +		/* fall through */
>   	default:
>   		return -1;	/* ignore unprintables */
>   	}