Re: [PATCH 4.9 000/107] 4.9.120-stable review

[Guenter Roeck]

On Wed, Aug 15, 2018 at 09:08:08PM +0200, Sebastian Gottschall wrote:
> 
> Am 15.08.2018 um 20:55 schrieb Guenter Roeck:
> >On Wed, Aug 15, 2018 at 08:27:00PM +0200, Sebastian Gottschall wrote:
> >>if i fix the other error (can be reproduced with disable smp on standard
> >>i386 build)
> >>
> >>another raises up again related to smp. to be serious. this patchset of x86
> >>patches is absolutelly broken and put together without any care. not a
> >>simple compile test has been done
> >>
> >>sorry for beeing a little bit upset. i'm sure i will find other bugs if i go
> >>deeper
> >>
> >It might possibly help if you would consider to publish your configuration(s).
> >
> >As for "not a simple compile test has been done", please have a look
> >at http://kerneltests.org/builders. I guess those compile (and boot)
> >tests don't count as "simple". I assume the same applies to all the
> >builds done by 0day and all the other test builders.
> >
> >Guenter
> 
> it was nothing special. just a standard x86 build with smp disabled. that
> triggers all of them. so this should be a common build configuration for
> testing
> these issues are covered by the rc3 patch of 4.9 right now
> 
> the issue reported by sven can be triggered by just compiling rtc-cmos.c
> which is caused by the change in dmi.h  (asm/io.h was replaced by
> linux/io.h)
> so this driver should be included in all x86 and x64 builds and must be
> uncovered in any simple compile test
> 
> btw. this issue is still unresolved but simple to fix
> 
> --- arch/x86/include/asm/i8259.h        (revision 36620)
> +++ arch/x86/include/asm/i8259.h        (working copy)
> @@ -2,6 +2,7 @@
>  #define _ASM_X86_I8259_H
> 
>  #include <linux/delay.h>
> +#include <asm/io.h>
> 

Also seen in mainline. Meaning my non-SMP test builds are broken. Hmm.

Anyway, care to send a proper patch ? I am sure Linus will be more
than happy to apply it.

Thanks,
Guenter