RE: [PATCH] rdma: move the ib_wr_opcode enum to include/uapi

[Howell, Seth]

Thank you for taking the time to review this issue. The patch you submitted will definitely fix the problem I was facing.

-----Original Message-----
From: Jason Gunthorpe [mailto:jgg@xxxxxxxx] 
Sent: Wednesday, August 15, 2018 3:50 PM
To: Howell, Seth <seth.howell@xxxxxxxxx>
Cc: Walker, Benjamin <benjamin.walker@xxxxxxxxx>; Doug Ledford <dledford@xxxxxxxxxx>; linux-rdma@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Moni Shoua <monis@xxxxxxxxxxxx>
Subject: Re: [PATCH] rdma: move the ib_wr_opcode enum to include/uapi

On Tue, Aug 14, 2018 at 03:33:02PM -0700, Seth Howell wrote:
> By making this enum accessible to the userspace API, we can avoid 
> conflicts between the kernel-space ib_wr_opcode and the user-space 
> ibv_wr_opcode enums.
> 
> When using the rxe software driver interface between kernel and user 
> space, the enum value IBV_WR_SEND_WITH_INV was being improperly 
> translated to IB_WR_READ_WITH_INV causing the userspace application to 
> fail.
> 
> Signed-off-by: Seth Howell <seth.howell@xxxxxxxxx>
>  include/rdma/ib_verbs.h           | 31 -------------------------------
>  include/uapi/rdma/ib_user_verbs.h | 31 
> +++++++++++++++++++++++++++++++
>  2 files changed, 31 insertions(+), 31 deletions(-)

I've looked at this for a bit now, and I think we should just do the below and not change userspace: